chore: isolate build for protocol and e2e tests #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
force-pushed
the
chore/move-tests-build-to-own-tsconfig
branch
5 times, most recently
from
802bb39 to
5e6a83a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #627 +/- ##
============================================
Coverage 54.52% 54.52%
============================================
Files 226 226
Lines 5199 5199
Branches 800 800
============================================
Hits 2835 2835
Misses 2127 2127
Partials 237 237 ☔ View full report in Codecov by Sentry. |
kanej
force-pushed
the
chore/move-tests-build-to-own-tsconfig
branch
9 times, most recently
from
39cac07 to
be1894b
Compare
This was previously implicit and depended on a the root build. This clashes with my attempts to update the typescript version, so I am scoping the e2e tests to their own build.
kanej
force-pushed
the
chore/move-tests-build-to-own-tsconfig
branch
from
be1894b to
af10d73
Compare
kanej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript build step for
./test/e2eand./test/protocolin our test suite was done by a global tsc build at the root of the project and based on the root./tsconfig.json.This created lots of pain points in upgrading the version of typescript. This PR introduces individual scoped builds for both
e2eandprotocol.New tsconfig files were introduced for each based on our other packages.